Launcher feature #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Launcher is an assembly language program which avoids memory consumption while DOSMENU is running. Note however the bugs still need to be resolved (it works, but it corrupts memory causing crashes when executing certain programs, e.g. Commander Keen 1)
1) We deallocated our stack, which meant it could be overwritten by the programs we launched. FIX: reserve 256 bytes for stack, and switch stacks at start of launcher, before deallocating memory This solves problem where we would crash upon exiting certain programs, such as Commander Keen 1. 2) We couldn't run .BAT files via launcher FIX: in dosmenu.c, change command to be executed to be %COMSPEC% (presumably COMMAND.COM), and put /C before arguments This solves problem where programs launched by batch files would not start if launcher was enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a separate executable written in assembly to maximise amount of conventional memory available to programs being run from the menu.