Skip to content

Fix import paths to use gonum.org/v1/gonum#237

Open
jasonzhuyx wants to merge 2 commits intosjwhitworth:masterfrom
jasonzhuyx:fix-import-path
Open

Fix import paths to use gonum.org/v1/gonum#237
jasonzhuyx wants to merge 2 commits intosjwhitworth:masterfrom
jasonzhuyx:fix-import-path

Conversation

@jasonzhuyx
Copy link
Copy Markdown

@jasonzhuyx jasonzhuyx commented Nov 13, 2019

Since December, 2018, both "gonum/blas" and "gonum/matrix" have been deprecated and migrated to "gonum/gonum".

As "go.mod" (at https://github.com/gonum/gonum) declares

module gonum.org/v1/gonum

this PR includes the changes to use "gonum.org/v1/gonum" as import paths in

  • knn/knn.go
  • linear_models/linear_regression.go
  • metrics/pairwise/chebyshev.go
  • metrics/pairwise/cranberra.go
  • metrics/pairwise/manhattan.go

@jasonzhuyx jasonzhuyx force-pushed the fix-import-path branch 2 times, most recently from 074f523 to 97f6212 Compare November 13, 2019 17:40
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 13, 2019

Codecov Report

Merging #237 into master will not change coverage.
The diff coverage is 75%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #237   +/-   ##
=======================================
  Coverage   70.78%   70.78%           
=======================================
  Files          68       68           
  Lines        5945     5945           
=======================================
  Hits         4208     4208           
  Misses       1392     1392           
  Partials      345      345
Impacted Files Coverage Δ
linear_models/linear_regression.go 93.84% <ø> (ø) ⬆️
knn/knn.go 76.09% <0%> (ø) ⬆️
metrics/pairwise/manhattan.go 100% <100%> (ø) ⬆️
metrics/pairwise/cranberra.go 100% <100%> (ø) ⬆️
metrics/pairwise/chebyshev.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fcc2b4...d252e11. Read the comment docs.

Comment thread knn/knn.go Outdated
Comment thread metrics/pairwise/chebyshev.go Outdated
Comment thread metrics/pairwise/cranberra.go Outdated
Comment thread metrics/pairwise/manhattan.go Outdated
@mattn mattn mentioned this pull request Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants