refactor(badge): redesign badge component #195
Open
jiji-hoon96 wants to merge 1 commit intorelease/v1from
Open
refactor(badge): redesign badge component #195jiji-hoon96 wants to merge 1 commit intorelease/v1from
jiji-hoon96 wants to merge 1 commit intorelease/v1from
Conversation
jiji-hoon96
requested review from
dev-hobin,
froggy1014,
haedawn,
leejiwonn,
noahluftyang and
synuns
as code owners
|
✅ Deploy Preview for side-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
froggy1014
reviewed
Aug 18, 2025
Comment on lines
+120
to
+170
| variants: { color: BadgeColor['1st'], variant: BadgeVariant.default }, | ||
| style: { | ||
| backgroundColor: colorToken.green100, | ||
| color: colorToken.green700, | ||
| }, | ||
| }, | ||
| // 2nd variants | ||
| { | ||
| variants: { color: BadgeColor['2nd'], variant: BadgeVariant.solid }, | ||
| style: { | ||
| backgroundColor: colorToken.purple500, | ||
| color: colorToken.white, | ||
| }, | ||
| }, | ||
| { | ||
| variants: { color: BadgeColor['2nd'], variant: BadgeVariant.default }, | ||
| style: { | ||
| backgroundColor: colorToken.purple100, | ||
| color: colorToken.purple700, | ||
| }, | ||
| }, | ||
| // 3rd variants | ||
| { | ||
| variants: { color: BadgeColor['3rd'], variant: BadgeVariant.solid }, | ||
| style: { | ||
| backgroundColor: colorToken.orange500, | ||
| color: colorToken.white, | ||
| }, | ||
| }, | ||
| { | ||
| variants: { color: BadgeColor['3rd'], variant: BadgeVariant.default }, | ||
| style: { | ||
| backgroundColor: colorToken.orange100, | ||
| color: colorToken.orange700, | ||
| }, | ||
| }, | ||
| // 4th variants | ||
| { | ||
| variants: { color: BadgeColor['4th'], variant: BadgeVariant.solid }, | ||
| style: { | ||
| backgroundColor: colorToken.cyan500, | ||
| color: colorToken.white, | ||
| }, | ||
| }, | ||
| { | ||
| variants: { color: BadgeColor['4th'], variant: BadgeVariant.default }, | ||
| style: { | ||
| backgroundColor: colorToken.cyan100, | ||
| color: colorToken.cyan700, | ||
| }, | ||
| }, |
Contributor
There was a problem hiding this comment.
색상이 어떤기준으로 잡힌지 모르겠어요 ~
ex) 2nd -> purple 이라던가
디자인 이슈라면 디자이너 호출 필요할듯
| size = BadgeSize.small, | ||
| variant = BadgeVariant.default, | ||
| color = BadgeColor.gray, | ||
| icon = 'none', |
Contributor
There was a problem hiding this comment.
leftIcon, rightIcon 프롭스로 넘어오면 icon 방향과 유무가 명확히 전달되는거 같은데, icon이라는 프롭이 필요한가요?
|
|
||
| expect(screen.getByRole('status')).toHaveStyle({ | ||
| backgroundColor: colorToken.cyan900, | ||
| describe('Badge', () => { |
Contributor
There was a problem hiding this comment.
뱃지 테스트 커버리지 70%도 안되다뇨 - 흑흑
| "clsx": "^2.1.1" | ||
| }, | ||
| "devDependencies": { | ||
| "@radix-ui/react-slot": "^1.1.0", |
Contributor
There was a problem hiding this comment.
react-slot가 devDependencies에 들어가있네욤
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the Badge component to align with Figma design specifications using Vanilla-Extract recipe pattern.
Changes
Visuals
Checklist
Additional Discussion Points