Failure with METHOD_ABSTRACT_ADDED_IN_IMPLEMENTED_INTERFACE over new class

[cstamas]

We compare two versions of Resolver (1.9.18 vs master), and build is failed as japicmp detects incompatibility:
https://gist.github.com/cstamas/bb8e200fda5b8988794e25fc172ce6ae

The problem is that this is new class in Resolver 2.x (nothing to compare against in Resolver 1.9.x).

Basically same as #281 but with japicmp version 0.24.1
See apache/maven-resolver#1617 CI jobs

The file japicmp fails:
https://github.com/apache/maven-resolver/blob/0dd7824b9926b8932b37c40dfb72786e3d016417/maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/visitor/NodeListGenerator.java

[siom79]

Does it also happen with 0.23.0?

[cstamas]

No, build is okay with 0.23.1, that dependabot tries to upgrade from.

Edit: tried with 0.23.0 as well, same: build is OK

[siom79]

In #281 I have added a test case, so I do not assume it is exactly the same.

First investigations show that it seems to be a problem with the implementation of a generic interface method:

@FunctionalInterface
public interface Consumer<T> {

    void accept(T t);

In the code that checks whether the method is implemented the compiled java.lang.Object is compared against DependencyNode. This seems to be wrong, wondering why this hasn't popped up earlier because there seems to be no connection to the latest changes in 0.24.1 and 0.24.0.

[cstamas]

To test, just use master of maven-resolver (in root POM is japicmp, so you can easily change version of it).

Well, "same" as "same message and case that this is new class, no old counterpart to compare with" 😃

[cstamas]

And many thanks for looking into this! 🍻

[siom79]

I have deployed a snapshot version here that seems to fix the issue on the dependabot-branch of maven-resolver.
Before I release a new version I need to perform some further tests.

[siom79]

Released with 0.24.2.