Remove object spread to support node >=8.0.0 <8.6.0 #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Sorry for the trouble |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Low priority fix: Change object spread back to
Object.assignsince engine.node is >=8.Another package on node 8 dependent on update-notifier was failing at the
notify()script withUnexpected token ...and not showing their "please upgrade node" warning. Node>=8.6 compiled ok, but everything below that resulted in the same error. Was going to open an issue there and PR, but decided just to PR here because there's only one instance of the object spreading and seemed like a better fix in case any other users were using lower 8x versions.xo default rule is "error" on
prefer-object-spread(which I'm sure you're aware as a member), so I turned that rule off in package.json to complete the tests. I left the warn "no warning comments" alone.