Improve the message error when attaching onCancel after the promise settled#31
Merged
sindresorhus merged 7 commits intosindresorhus:mainfrom Apr 24, 2022
jopemachine:fix-attach-err-msg
Merged
Improve the message error when attaching onCancel after the promise settled#31sindresorhus merged 7 commits intosindresorhus:mainfrom jopemachine:fix-attach-err-msg
sindresorhus merged 7 commits intosindresorhus:mainfrom
jopemachine:fix-attach-err-msg
Conversation
Contributor
Author
|
CI logs say Should I add |
Contributor
Author
|
I found the same looking issue on xojs/xo#555, could this issue be resolved through upgrade xo to 0.46.0 or higher? |
Owner
Yes |
Owner
|
Linting is failing |
Contributor
Author
|
It seems we need to drop Node 8, and 10 in CI because this module is ESM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23.