Immediately call onCancel handlers when a promise is canceled

[jonschlinkert]

Fixes #15

[szmarczak]

Can you undo this change? A much better solution is to move the this._isCanceled = true; before the if here:

https://github.com/jonschlinkert/p-cancelable/blob/deaeee112adc3d105aaec2074de971af5dd48c3a/index.js#L90-L100

[sindresorhus]

4b7d014

[szmarczak]

Suggested change

	if (this._isCanceled !== true || onCancel.shouldReject === false) {
	if (!this._isCanceled || !onCancel.shouldReject) {

[szmarczak]

Add a test:

test('throws immediately as soon as .cancel() is called', async t => {
	const cancelablePromise = new PCancelable((resolve, reject, onCancel) => {
	const timeout = setTimeout(() => {
		resolve(true);
	}, 10);
	
	onCancel.shouldReject = true;
	onCancel(() => {
		clearTimeout(timeout);
		resolve(false);
	  });
	});

	cancelablePromise.cancel();

	await t.throwsAsync(cancelablePromise, {
		message: 'Promise was canceled'
	});
});

[ifiokjr]

Is this still being worked on?

I'm happy to help out if not.

[szmarczak]

@ifiokjr That would be great! I don't think the author is active on GitHub anymore (I just guess by looking at his contributions chart).

[sindresorhus]

Friendly bump :)

[jonschlinkert]

Oh wow, I totally forgot. Thanks for the ping.

…

Sent from my iPhone

On Mar 7, 2021, at 6:58 AM, Sindre Sorhus ***@***.***> wrote:  Friendly bump :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[sindresorhus]

Thanks :)