Add allowIndexParameter option to no-array-for-each
#2499
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Sorry to disappoint, but we only target the latest JavaScript version here and we will not include any option to support older JS versions. I recommend disabling the rule if you cannot use |
Author
|
No stress - thank you for the quick response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using unicorn in roblox-ts, the
no-array-for-eachsuggests that it should convert a for loop tofor (const [index, value] of foo.entries()) {. Yet,array.entries()does not exist.array.entries()also was introduced in ES6 I believe, so adding this paramater would support ES5 code (although very rare these days!) and other runtimes that do not supportarray.entries()yet still want to use unicorn (e.g. assemblyscript).