OneBotApi支持指定method与自定义的URL操作； 调整部分依赖配置 #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
A PR to support custom HTTP methods and URL operations in OneBotApi while adjusting dependency configurations.
- Introduces customizable HTTP methods and URL resolution via new API properties and functions in OneBotApi.
- Updates Gradle dependency configurations to expose key libraries as API dependencies.
- Adds a new test case to verify custom GET API functionality.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| simbot-component-onebot-v11-message/build.gradle.kts | Changed kotlin serialization dependency from implementation to api. |
| simbot-component-onebot-v11-event/build.gradle.kts | Updated kotlin serialization dependency to api for consistent public access. |
| simbot-component-onebot-v11-core/api/OneBotApi.kt | Added properties and functions (method, resolveUrlAction, resolveUrlExtensions) for customizable API requests. |
| simbot-component-onebot-v11-core/src/commonTest/kotlin/love/forte/simbot/component/onebot/v11/core/api/ApiRequestTests.kt | Added custom GET API test verifying method and URL parameter functionality. |
| simbot-component-onebot-v11/simbot-component-onebot-v11-common/build.gradle.kts | Adjusted dependency exposure from implementation to api for common annotations. |
| simbot-component-onebot-common/build.gradle.kts | Removed redundant compileOnly dependency in jvmMain. |
Comments suppressed due to low confidence (3)
simbot-component-onebot-common/build.gradle.kts:59
- The removal of the jvmMain compileOnly dependency may affect build configuration; please verify that this dependency is no longer required for proper module compilation.
jvmMain { dependencies { compileOnly(libs.simbot.api) } }
simbot-component-onebot-v11/simbot-component-onebot-v11-message/build.gradle.kts:66
- Changing the serialization dependency from 'implementation' to 'api' exposes it to consumers; please confirm that this design decision is intended for proper dependency management.
api(libs.kotlinx.serialization.json)
simbot-component-onebot-v11/simbot-component-onebot-v11-event/build.gradle.kts:60
- Ensure that updating the serialization dependency to 'api' in the event module aligns with the overall design, providing necessary exposure for dependent modules.
api(libs.kotlinx.serialization.json)
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #205