Add community version controlnet performance testing#557
Merged
Conversation
strint
reviewed
Jan 23, 2024
Collaborator
|
性能数据都加到 readme 吧 |
strint
approved these changes
Jan 23, 2024
doombeaker
reviewed
Jan 23, 2024
| @@ -0,0 +1,115 @@ | |||
| import matplotlib as mpl | |||
Contributor
There was a problem hiding this comment.
py 文件（以及 config.yaml）不适合放在 imgs 目录下，imgs 下最好只放图片。
可以在仓库根目录下，新建一个 tools 一类的文件夹，放这两个文件吧。
或者放到已有的 benchmarks 目录下
| plt.savefig(config["output_filename"], dpi=config["figure"]["dpi"], bbox_inches="tight") | ||
|
|
||
| # Show the plot | ||
| plt.show() |
| @@ -0,0 +1,44 @@ | |||
| categories: | |||
Contributor
There was a problem hiding this comment.
我建议这里的配置，直接改成这个 PR 里那个 comfy_commnity_version_speed.png 图片一致的配置。
这样两者其实是互相解释的。这个 PR 后续对于其它要使用或者维护的人，是现成的学习资料。
Contributor
There was a problem hiding this comment.
像现有的 png 里，有些属性没有用到，比如 plot_title，我觉得也最好用起来。图片里能体现的，尽量体现（不让人觉得累赘的前提下）。图片里不能体现的，在 config.yaml 里写下说明注释
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance Comparison
Timings for 20 steps at 1024x1024
Image throughput for 20 steps at 1024x1024