Include SCT extension in signature data#1659
Merged
woodruffw merged 1 commit intosigstore:mainfrom Jan 16, 2026
Merged
Conversation
If an SCT includes an extension, its signature is signed over the entire data structure including the extension. Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
Member
|
/gcbrun |
This was referenced Jan 16, 2026
Closed
jku
pushed a commit
to jku/sigstore-python
that referenced
this pull request
Jan 26, 2026
jku
added a commit
that referenced
this pull request
Jan 26, 2026
* Remove suspicion of extension bytes (#1657) * Include SCT extension in signature data (#1659) * Add state validation to OIDC flow to prevent CSRF The OIDC flow in did not verify the `state` parameter returned by the identity provider against the state sent in the request. This could allow tricking the user into using an authorization code obtained by the attacker. All of the response parsing should arguably be moved to _OAuthRedirectServer (to hide the details from `sigstore.oidc`) but I wanted to keep this fix minimal. Test generated by AI. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com> * Update version to 3.6.7, update CHANGELOG Signed-off-by: Jussi Kukkonen <jkukkonen@google.com> --------- Signed-off-by: Jussi Kukkonen <jkukkonen@google.com> Co-authored-by: Colleen Murphy <cmurphy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an SCT includes an extension, its signature is signed over the entire data structure including the extension.
Followup to #1657
Relates to sigstore/rekor-tiles#73
Fixes conformance failure in https://github.com/sigstore/sigstore-conformance/actions/runs/21049488308/job/60532184810?pr=319
Summary
Release Note
Documentation