chore: remove an unused nonce from OAuth flow#1649
Merged
Conversation
Signed-off-by: William Woodruff <william@astral.sh>
woodruffw
commented
Jan 8, 2026
|
|
||
| class _OAuthRedirectHandler(http.server.BaseHTTPRequestHandler): | ||
| def log_message(self, _format: str, *_args: Any) -> None: | ||
| def log_message(self, format: str, *_args: Any) -> None: |
Member
Author
There was a problem hiding this comment.
Note: fixed this as a very minor but technically invalid Liskov Substitution.
Member
Author
|
This error makes zero sense to me: I don't understand how it even sees that Ah, this is probably pypa/pip#9644. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our OAuth flow uses
authorization_code, in whichnonceis not required and has no effect.