Update supported public key algorithms.#1604
Merged
jku merged 4 commits intosigstore:mainfrom Nov 6, 2025
Merged
Conversation
woodruffw
approved these changes
Nov 5, 2025
Hayden-IO
approved these changes
Nov 5, 2025
jku
approved these changes
Nov 6, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some algorithms we were supporting that fulcio doesn't support.
Additionally, it doesn't appear that we were supporting
PKIX_RSA_PKCS1V15_2048_SHA256, and we were incorrectly setting the key details forPKIX_RSA_PKCS1V15_4096_SHA256.Also adds tests to get to 100% coverage for unsupported edge cases.
Fixes #1603.