trust: Fail less hard when unsupported keys are seen#1424
Merged
jku merged 1 commit intosigstore:mainfrom Jun 5, 2025
Merged
Conversation
Member
Author
|
I'm thinking of backporting this fix to a 3.6.x branch:
|
Currently verification fails immediately if trusted root contains any unsupported keys. I think it makes more sense to warn and continue as it is possible these keys are not required for verification. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
jku
force-pushed
the
fail-softly-on-unsupported-keys
branch
from
887889c to
591ede8
Compare
jku
added a commit
to jku/sigstore-python
that referenced
this pull request
Jun 5, 2025
Don't fail hard if trusted root contains an unknown key type: Verification may still succeed so warning is enough. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Member
Author
|
Marking this a draft while I do another test with the (future) staging trusted root EDIT: Tested, looks good to me |
woodruffw
approved these changes
Jun 5, 2025
Member
Sounds good to me -- I see you opened the backport PR, give me a ping on it when it's ready for review 🙂 |
jku
added a commit
that referenced
this pull request
Jun 6, 2025
* Backport #1424 Don't fail hard if trusted root contains an unknown key type: Verification may still succeed so warning is enough. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com> * Prep 3.6.3 This release only contains a small fix for handling of unsupported keytypes in the trusted root. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com> --------- Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
jku
added a commit
to jku/sigstore-python
that referenced
this pull request
Oct 14, 2025
Fail less hard when unsupported keys are seen Current trusted root contains keys this client version does not understand: the keys are not necessary to verify or sign bundles with rekor v1 Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
jku
added a commit
to jku/sigstore-python
that referenced
this pull request
Oct 14, 2025
Fail less hard when unsupported keys are seen Current trusted root contains keys this client version does not understand: the keys are not necessary to verify or sign bundles with rekor v1 Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
jku
added a commit
that referenced
this pull request
Oct 24, 2025
* Backport: internal/trust: Fix bug in rekor key lookup Rekor keyring can (and in future will) have multiple keys: logs not only get sharded but once rekor-tiles is integrated in the public good instance, there will be two writable logs for a while. Backport of #1350 Signed-off-by: Jussi Kukkonen <jkukkonen@google.com> * Backport #1424 Fail less hard when unsupported keys are seen Current trusted root contains keys this client version does not understand: the keys are not necessary to verify or sign bundles with rekor v1 Signed-off-by: Jussi Kukkonen <jkukkonen@google.com> * Backport: ci: fix offline tests on ubuntu-latest Backport of #1283 Signed-off-by: Jussi Kukkonen <jkukkonen@google.com> * Bump 3.5.x series to 3.5.4 Signed-off-by: Jussi Kukkonen <jkukkonen@google.com> --------- Signed-off-by: Jussi Kukkonen <jkukkonen@google.com> Co-authored-by: William Woodruff <william@trailofbits.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently verification fails immediately if trusted root contains any unsupported keys. I think it makes more sense to warn and continue as it is possible these keys are not required for verification.
Unfortunately I missed this case when I tested the multiple log support in #1350 :(