Fix warning for CLI verification of legacy bundles#1198
Merged
woodruffw merged 2 commits intosigstore:mainfrom Oct 28, 2024
Merged
Fix warning for CLI verification of legacy bundles#1198woodruffw merged 2 commits intosigstore:mainfrom
woodruffw merged 2 commits intosigstore:mainfrom
Conversation
woodruffw
previously approved these changes
Oct 28, 2024
Member
woodruffw
left a comment
woodruffw
left a comment
There was a problem hiding this comment.
Nice work @facutuesca! Mind adding a CHANGELOG entry, since this fixes my broken fix?
Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
facutuesca
force-pushed
the
fix-warning-legacy
branch
from
a73e1b1 to
82599ef
Compare
Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
facutuesca
force-pushed
the
fix-warning-legacy
branch
from
82599ef to
7965d75
Compare
Collaborator
Author
Done! |
Member
|
/gcbrun |
woodruffw
approved these changes
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a check in the CLI command
sigstore verifywhere we should have printed a warning while verifying a legacy bundle (*.sigstore) if no bare materials (*.crtand*.sig) are provided.The warning was never printed, due to an error in the check that made it always return
False.This PR also adds a regression test for the bug fixed in #1192, checking that the CLI correctly verifies a legacy bundle and that it logs the expected warning.
This closes #1194.
cc @woodruffw