_cli: files always take precedence over digests#1152
Merged
Conversation
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
facutuesca
approved these changes
Oct 2, 2024
Collaborator
facutuesca
left a comment
facutuesca
left a comment
There was a problem hiding this comment.
...that was an edge case that I wasn't expecting at all.
LGTM! I'll make a note to add a test for it when we write the CLI verify tests
jku
approved these changes
Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a small edge case where a user supplies
sha256:hash.jsonlor similar (such as produced by default bygh attestation) and thesigstore verifysubcommands interpret it as an (invalid) hash rather than a file input.The new behavior is to always interpret the input as a path if a file at that path is extant, and to otherwise interpret it as a hash.
CC @facutuesca