-
Notifications
You must be signed in to change notification settings - Fork 76
_internal.tuf: exception handling #357
Copy link
Copy link
Closed
Labels
component:tufTUF related componentsTUF related componentsenhancementNew feature or requestNew feature or request
Description
#351 is going to add sigstore._internal.tuf module. It does not handle errors consistently at the moment.
@woodruffw on error handling:
sigstore-python needs some exception refactoring anyways, and we could probably do a better job with the overall refactor by batching any handling here into those changes.
In that light, I'll just document the current sigstore._internal.tuf.TrustUpdater situation here:
- constructors may raise
OSErroron file read/write errors
TrustUpdater.get_*()methods may raiseOSErroron file read/write errors- python-tuf
DownloadErrorwhen we fail to download something from remote (metadata or target file) - python-tuf
RepositoryErrorwhen the metadata is not valid -- repository is in a state that means we can't continue - parsing errors in
TrustUpdater._get()code: metadata was valid TUF metadata but does not contain what we expected
Some of these we might not want to handle (like OSError) but e.g. DownloadError could be a fairly common occurrence with network hiccups and such?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
component:tufTUF related componentsTUF related componentsenhancementNew feature or requestNew feature or request