Skip to content

Fix Bun compatability: base64 DER key parsing and default to sha256 for verify#1561

Open
PowerSpy wants to merge 1 commit intosigstore:mainfrom
PowerSpy:fix/bun-compatability
Open

Fix Bun compatability: base64 DER key parsing and default to sha256 for verify#1561
PowerSpy wants to merge 1 commit intosigstore:mainfrom
PowerSpy:fix/bun-compatability

Conversation

@PowerSpy
Copy link

Added patches to ensure Bun/BoringSSL compatibility in sigstore-js:

  1. Base64 DER public key parsing:

    • Ensures createPublicKey handles base64 encoded DER keys correctly.
  2. Default to SHA256 when verifying:

    • verify() defaults to 'sha256' if no algorithm is provided.

Changes allow for better Bun compatibility for creating keys and verifying.

Summary

This PR adds patches to ensure sigstore-js works correctly in Bun/BoringSSL environments.

Specifically:

  1. Base64 DER parsing in createPublicKey.
  2. verify() defaults to SHA-256 if no algorithm is provided.

Release Note

Fix: Improved Bun/BoringSSL compatibility.

Documentation

No documentation changes required; this improves Bun compatibility.

…or verify

Added patches to ensure Bun/BoringSSL compatibility in sigstore-js:

1. Base64 DER public key parsing:
    - Ensures createPublicKey handles base64 encoded DER keys correctly.

2. Default to SHA256 when verifying:
    - verify() defaults to 'sha256' if no algorithm is provided.

Changes allow for better Bun compatibility for creating keys and verifying.
@PowerSpy PowerSpy requested a review from a team as a code owner January 14, 2026 07:01
@changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2026

⚠️ No Changeset found

Latest commit: 929a635

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant