Skip to content

Conversation

cmurphy
Copy link
Contributor

@cmurphy cmurphy commented Jul 2, 2025

Add --ctfe-end-time and and --rekor-end-time to cosign trusted-root create to accompany the start time flags. This is necessary to declare a transparency log instance is being turned down and force clients to move to the newer instance.

Summary

Release Note

Documentation

@cmurphy cmurphy requested a review from a team as a code owner July 2, 2025 23:17
@cmurphy
Copy link
Contributor Author

cmurphy commented Jul 2, 2025

Copy link

codecov bot commented Jul 2, 2025

Codecov Report

Attention: Patch coverage is 21.42857% with 22 lines in your changes missing coverage. Please review.

Project coverage is 34.36%. Comparing base (2ef6022) to head (0b90bd8).
Report is 426 commits behind head on main.

Files with missing lines Patch % Lines
cmd/cosign/cli/trustedroot/trustedroot.go 33.33% 11 Missing and 1 partial ⚠️
cmd/cosign/cli/options/trustedroot.go 0.00% 8 Missing ⚠️
cmd/cosign/cli/trustedroot.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4271      +/-   ##
==========================================
- Coverage   40.10%   34.36%   -5.74%     
==========================================
  Files         155      211      +56     
  Lines       10044    14085    +4041     
==========================================
+ Hits         4028     4841     +813     
- Misses       5530     8630    +3100     
- Partials      486      614     +128     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

haydentherapper
haydentherapper previously approved these changes Jul 2, 2025
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@haydentherapper
Copy link
Contributor

Oh, gotta run make docgen

Add --ctfe-end-time and and --rekor-end-time to `cosign trusted-root
create` to accompany the start time flags. This is necessary to declare
a transparency log instance is being turned down and force clients to
move to the newer instance.

Signed-off-by: Colleen Murphy <[email protected]>
@haydentherapper haydentherapper enabled auto-merge (squash) July 7, 2025 18:49
@haydentherapper haydentherapper merged commit 49c8d78 into sigstore:main Jul 7, 2025
29 checks passed
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jul 28, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [cosign](https://github.com/sigstore/cosign) | patch | `2.5.2` -> `2.5.3` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>sigstore/cosign (cosign)</summary>

### [`v2.5.3`](https://github.com/sigstore/cosign/blob/HEAD/CHANGELOG.md#v253)

[Compare Source](sigstore/cosign@v2.5.2...v2.5.3)

#### Features

- Add signing-config create command ([#&#8203;4280](sigstore/cosign#4280))
- Allow multiple services to be specified for trusted-root create ([#&#8203;4285](sigstore/cosign#4285))
- feat: Add OCI 1.1+ experimental support to tree ([#&#8203;4205](sigstore/cosign#4205))
- Add validity period end for trusted-root create ([#&#8203;4271](sigstore/cosign#4271))

#### Bug Fixes

- Fix cert verification logic for trusted-root/SCTs ([#&#8203;4294](sigstore/cosign#4294))
- force when copying the latest image to overwrite ([#&#8203;4298](sigstore/cosign#4298))
- avoid double-loading trustedroot from file ([#&#8203;4264](sigstore/cosign#4264))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC42Mi4xIiwidXBkYXRlZEluVmVyIjoiNDAuNjIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants