feat(gossipsub): report low score peers #575
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protocols/gossipsub/src/behaviour.rs
Outdated
| @@ -164,6 +164,8 @@ pub enum Event { | |||
| /// The types and amounts of failed messages that are occurring for this peer. | |||
| failed_messages: FailedMessages, | |||
| }, | |||
| /// A Peer is below the score threshold. | |||
| LowScorePeers { peer_ids: Vec<PeerId> }, | |||
There was a problem hiding this comment.
yup, makes sense, Thanks Diego
| let mut to_remove_peers = Vec::new(); | ||
| for peer_id in peers.iter() { | ||
| // report peers below the score report threshold. | ||
| let mut removed_peers = 0; |
There was a problem hiding this comment.
Is it a good idea to change to_remove_peer in this PR? It doesn't seem related
There was a problem hiding this comment.
it's not directly related, but since I am touching this code might as well take the opportunity to cleanup this part
jxs
force-pushed
the
report-lowscore-peers
branch
from
f14936a to
397c09c
Compare
jxs
force-pushed
the
report-lowscore-peers
branch
from
397c09c to
4b04c2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notes & open questions
Change checklist