Skip to content

Conversation

@0xmrree
Copy link

@0xmrree 0xmrree commented Dec 29, 2025

Issue Addressed

8571

Proposed Changes

Did a quick inventory and found that the following was in the spec config at https://github.com/ethereum/consensus-specs/blob/master/configs/mainnet.yaml but not in lighthouse's /eth/v1/config/spec. This is of course not including the configs added via: 8603 and 8601

SLOT_DURATION_MS
PROPOSER_REORG_CUTOFF_BPS
ATTESTATION_DUE_BPS
AGGREGATE_DUE_BPS
CONTRIBUTION_DUE_BPS
SYNC_MESSAGE_DUE_BPS

Additional Info

Surprisingly, even tho the above configs in the ChainSpec struct, none of them are actually being used. For now adding them to spec API would be good to keep things consistent across clients I would assume. Also these values from the chain spec are not being read from the config - I did not make it so, such that I don't have to change the gnosis config.yaml

Testing

unit tests and ran

curl http://localhost:5052/eth/v1/config/spec | jq '.data | {
 SLOT_DURATION_MS,
 PROPOSER_REORG_CUTOFF_BPS,
 ATTESTATION_DUE_BPS,
 AGGREGATE_DUE_BPS,
 CONTRIBUTION_DUE_BPS,
 SYNC_MESSAGE_DUE_BPS
}'

@0xmrree
Copy link
Author

0xmrree commented Dec 29, 2025

cc: @eth2353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant