Add rest of missing specs to spec api #8613
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
8571
Proposed Changes
Did a quick inventory and found that the following was in the spec config at https://github.com/ethereum/consensus-specs/blob/master/configs/mainnet.yaml but not in lighthouse's
/eth/v1/config/spec. This is of course not including the configs added via: 8603 and 8601SLOT_DURATION_MS
PROPOSER_REORG_CUTOFF_BPS
ATTESTATION_DUE_BPS
AGGREGATE_DUE_BPS
CONTRIBUTION_DUE_BPS
SYNC_MESSAGE_DUE_BPS
Additional Info
Surprisingly, even tho the above configs in the ChainSpec struct, none of them are actually being used. For now adding them to spec API would be good to keep things consistent across clients I would assume. Also these values from the chain spec are not being read from the config - I did not make it so, such that I don't have to change the gnosis config.yaml
Testing
unit tests and ran