-
Notifications
You must be signed in to change notification settings - Fork 952
Reduce noise in Debug impl of RuntimeVariableList
#8007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
38e3906 to
ddb6d7d
Compare
ddb6d7d to
5c73a33
Compare
|
Some required checks have failed. Could you please take a look @jimmygchen? 🙏 |
michaelsproul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The max_len doesn't seem as nasty as the typenum we were logging in ssz_types, but happy to remove it anyway.
I guess having it could sometimes be useful for debugging config issues? Similar to what Pawan suggested on the ssz_types PR:
Yep I can implement something like |
7f4ecd1 to
694b99b
Compare
|
Some required checks have failed. Could you please take a look @jimmygchen? 🙏 |
michaelsproul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You can check the last failing draft PR here: #8019. You may have to fix your CI before adding the pull request to the queue again. |
|
@mergify requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
The default debug output of these types contains a lot of unnecessary noise making it hard to read. This PR removes the type and extra fields from debug output to make logs easier to read. `len` could be potentially useful in some cases, but this gives us flexibility to only log it separately if we need it. Related PR in `ssz_types`: - sigp/ssz_types#57 Co-Authored-By: Jimmy Chen <[email protected]>
The default debug output of these types contains a lot of unnecessary noise making it hard to read. This PR removes the type and extra fields from debug output to make logs easier to read. `len` could be potentially useful in some cases, but this gives us flexibility to only log it separately if we need it. Related PR in `ssz_types`: - sigp/ssz_types#57 Co-Authored-By: Jimmy Chen <[email protected]>
The default debug output of these types contains a lot of unnecessary noise making it hard to read. This PR removes the type and extra fields from debug output to make logs easier to read. `len` could be potentially useful in some cases, but this gives us flexibility to only log it separately if we need it. Related PR in `ssz_types`: - sigp/ssz_types#57 Co-Authored-By: Jimmy Chen <[email protected]>
Issue Addressed
The default debug output of these types contains a lot of unnecessary noise making it hard to read.
This PR removes the type and extra fields from debug output to make logs easier to read.
lencould be potentially useful in some cases, but this gives us flexibility to only log it separately if we need it.Related PR in
ssz_types:Debugimpl ofVariableListandFixedVectorssz_types#57RuntimeVariableListBefore
Before:
After:
RuntimeFixedVectorBefore
After