Skip to content

Conversation

@pawanjay176
Copy link
Member

Issue Addressed

N/A

Proposed Changes

In #7897 , we seem to have modified data columns by range to return all the columns we have for the requested epoch disregarding what columns the peer requested.

@pawanjay176 pawanjay176 requested a review from jxs as a code owner August 26, 2025 18:19
@pawanjay176 pawanjay176 requested review from jimmygchen and removed request for jxs August 26, 2025 18:20
@pawanjay176 pawanjay176 added ready-for-review The code is ready for review fulu Required for the upcoming Fulu hard fork labels Aug 26, 2025
@mergify
Copy link

mergify bot commented Aug 26, 2025

Some required checks have failed. Could you please take a look @pawanjay176? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Aug 26, 2025
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, I've added a regression test as well

@jimmygchen jimmygchen added v8.0.0-rc.0 Q3 2025 release for Fusaka on Holesky ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Aug 27, 2025
@mergify
Copy link

mergify bot commented Aug 27, 2025

This pull request has been removed from the queue for the following reason: pull request manually updated.

The pull request #7942 has been manually updated.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

@mergify
Copy link

mergify bot commented Aug 27, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

# Conflicts:
#	beacon_node/network/src/network_beacon_processor/tests.rs
@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-merge This PR is ready to merge. labels Aug 27, 2025
mergify bot added a commit that referenced this pull request Aug 27, 2025
@mergify
Copy link

mergify bot commented Aug 27, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@jimmygchen
Copy link
Member

@mergify requeue

@mergify
Copy link

mergify bot commented Aug 27, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request Aug 27, 2025
@mergify mergify bot merged commit ccf03e1 into sigp:unstable Aug 27, 2025
33 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fulu Required for the upcoming Fulu hard fork ready-for-merge This PR is ready to merge. v8.0.0-rc.0 Q3 2025 release for Fusaka on Holesky

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants