-
Notifications
You must be signed in to change notification settings - Fork 952
Fix data columns by range returning all columns #7942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Some required checks have failed. Could you please take a look @pawanjay176? 🙏 |
jimmygchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, I've added a regression test as well
|
This pull request has been removed from the queue for the following reason: The pull request #7942 has been manually updated. If you want to requeue this pull request, you can post a |
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You may have to fix your CI before adding the pull request to the queue again. |
# Conflicts: # beacon_node/network/src/network_beacon_processor/tests.rs
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You may have to fix your CI before adding the pull request to the queue again. |
|
@mergify requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Issue Addressed
N/A
Proposed Changes
In #7897 , we seem to have modified data columns by range to return all the columns we have for the requested epoch disregarding what columns the peer requested.