Remove ttfb_timeout and resp_timeout

[ackintosh]

Issue Addressed

TTFB_TIMEOUT was deprecated in ethereum/consensus-specs#3767.

Proposed Changes

Remove ttfb_timeout from InboundUpgrade and other related structs.

(Update)
Also removed resp_timeout and also removed the NetworkParams struct since its fields are no longer used. #7925 (comment)

Additional Info

I didn't remove ttfb_timeout field from ChainSpec because the field still exists in the mainnet.yaml file.

[pawanjay176]

LGTM. In terms of removing it from the config values, there is now a spec PR that removes both ttfb and resp timeouts ethereum/consensus-specs#4532

I think we should still keep the resp timeout with a value of 10, not sure if we should change it. cc @AgeManning

[AgeManning]

I agree, we should keep the timeout. It would stall sync and cause a bunch of issues if we don't timeout requests.

[pawanjay176]

Awesome, @ackintosh can we remove resp_timeout config param as well and use a constant value set to 10 seconds for the stream timeout?
We can merge that and then remove the config values once that gets upstreamed.

[ackintosh]

Thanks @pawanjay176! I removed resp_timeout as well, and also removed the NetworkParams struct since its fields are no longer used. The NetworkParams::max_payload_size field had already been unused before.

[pawanjay176]

LGTM, removed the NetworkParams struct like you mentioned and merged unstable.
Upstream PR also got merged, I think we should remove other references of ttfb_timeout and resp_timeout from the ChainSpec in a separate PR to give time for tooling to catch up. Will merge once CI passes

[mergify]

Some required checks have failed. Could you please take a look @ackintosh? 🙏