Fulu update to spec v1.6.0-alpha.4 #7890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
force-pushed
the
specs-v1.6.0-alpha.4
branch
from
7c84100 to
61a85a0
Compare
jimmygchen
force-pushed
the
specs-v1.6.0-alpha.4
branch
from
61a85a0 to
25e4f02
Compare
jimmygchen
added
ready-for-review
|
Some required checks have failed. Could you please take a look @jimmygchen? 🙏 |
mergify
bot
added
waiting-on-author
jimmygchen
added
ready-for-review
jimmygchen
added a commit
that referenced
this pull request
Aug 18, 2025
Squashed commit of the following: commit 4c687ba Author: Jimmy Chen <[email protected]> Date: Mon Aug 18 23:32:55 2025 +1000 Remove `NUMBER_OF_COLUMNS` from all config yaml files. commit 4bb5d72 Author: Jimmy Chen <[email protected]> Date: Mon Aug 18 23:21:42 2025 +1000 Ignore EIP-7916 and fix some `fake_crypto` tests. commit 21af25f Author: Jimmy Chen <[email protected]> Date: Mon Aug 18 17:40:37 2025 +1000 Add support for additional typenum values in type_dispatch macro commit 25e4f02 Author: Jimmy Chen <[email protected]> Date: Mon Aug 18 16:06:06 2025 +1000 Change `number_of_columns` from config to a preset value.
2 tasks
ethDreamer
reviewed
Aug 19, 2025
ethDreamer
reviewed
Aug 19, 2025
ethDreamer
reviewed
Aug 19, 2025
ethDreamer
approved these changes
Aug 19, 2025
Member
ethDreamer
left a comment
ethDreamer
left a comment
There was a problem hiding this comment.
Looks good to me! Some small recommendations but not married to them.
jimmygchen
added
ready-for-merge
6 tasks
Member
Author
|
@Mergifyio requeue |
☑️ This pull request is already queued |
6 tasks
michaelsproul
approved these changes
Aug 20, 2025
| .collect::<Vec<_>>(); | ||
| let all_data_columns = | ||
| RuntimeVariableList::from_vec(all_data_columns, self.spec.number_of_columns as usize); | ||
| RuntimeVariableList::from_vec(all_data_columns, T::EthSpec::number_of_columns()); |
Member
There was a problem hiding this comment.
Could this (eventually) become a VariableList now that the max length is determined at compile-time by the preset?
I guess it doesn't matter, as this vec seems only to be used for verification
Member
Author
There was a problem hiding this comment.
Yeah thats right. I tried doing that and it didn't make any difference, so i ended up reverting it
| JustificationAndFinalization, ParticipationFlagUpdates, ParticipationRecordUpdates, | ||
| PendingBalanceDeposits, PendingConsolidations, ProposerLookahead, RandaoMixesReset, | ||
| RegistryUpdates, RewardsAndPenalties, Slashings, SlashingsReset, SyncCommitteeUpdates, | ||
| Case, EffectiveBalanceUpdates, Eth1DataReset, FeatureName, HistoricalRootsUpdate, |
Member
There was a problem hiding this comment.
Does the reordering of these imports imply we aren't running cargo fmt on our tests?
Member
Author
There was a problem hiding this comment.
I removed DataColumnsByRootIdentifierWrapper, so the position of line break changed.
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2025
Fixes #7926 This was a bug I introduced in #7890 and @pawanjay176 noticed it on some running nodes, and added a rpc test to confirm it. The culprit is this line, where I failed to fill the vec to it's max size, so it doesn't calculate the max size properly, resulting in all `DataColumnByRoot` requests exceeding the max size during validation: https://github.com/sigp/lighthouse/blob/d24a6d2a45f25dfdba8740d10c569226555a8143/consensus/types/src/chain_spec.rs#L1984 The PR fixes this and includes new regression tests for this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Fulu update to spec v1.6.0-alpha.4.
number_of_columnsa presetget_custody_groupsto avoid computing if cgc = 128