Remove cargo test targets, use nextest exclusively #7874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
approved these changes
Aug 14, 2025
Member
|
target-branch-check will fail until you rebase on unstable/push a new empty commit (it doesn't recognise changing the branch in the GH UI) |
Removes cargo test-based Make targets (test-release, test-debug, run-ef-tests) and updates aliases to use nextest equivalents. Updates contributing documentation to use nextest examples and fixes example commands that previously suggested non-existing packages. CI workflows are updated to match the new make targets. This resolves contributor workflow inconsistency where local development used cargo test while CI used nextest. Based on benchmarks showing nextest is 1.02x faster than cargo test. Fixes sigp#7835
danielrachi1
force-pushed
the
rm_cargo_test_targets
branch
from
00e7c38 to
ad3184c
Compare
Contributor
Author
|
Hmm, CI thinks "nextest" is a misspelled word... idk what to do about this. |
Member
|
add it to wordlist.txt |
Contributor
Author
|
I think this is ready for merge @michaelsproul |
jimmygchen
approved these changes
Sep 10, 2025
Member
jimmygchen
left a comment
jimmygchen
left a comment
There was a problem hiding this comment.
Nice clean up, thanks @danielrachi1 !
6 tasks
PoulavBhowmick03
pushed a commit
to PoulavBhowmick03/lighthouse
that referenced
this pull request
Sep 12, 2025
Fixes sigp#7835 - Remove cargo test-based Make targets (`test-release`, `test-debug`, `run-ef-tests`) - Update aliases (`test`, `test-full`, `test-ef`) to use existing nextest equivalents - Update contributing documentation to use nextest examples - Fix example commands that previously referenced non-existing packages (`ssz`/`eth2_ssz`) Co-Authored-By: Daniel Ramirez-Chiquillo <[email protected]>
kevaundray
pushed a commit
to kevaundray/lighthouse
that referenced
this pull request
Sep 13, 2025
Fixes sigp#7835 - Remove cargo test-based Make targets (`test-release`, `test-debug`, `run-ef-tests`) - Update aliases (`test`, `test-full`, `test-ef`) to use existing nextest equivalents - Update contributing documentation to use nextest examples - Fix example commands that previously referenced non-existing packages (`ssz`/`eth2_ssz`) Co-Authored-By: Daniel Ramirez-Chiquillo <[email protected]>
jtraglia
pushed a commit
to jtraglia/lighthouse
that referenced
this pull request
Sep 16, 2025
Fixes sigp#7835 - Remove cargo test-based Make targets (`test-release`, `test-debug`, `run-ef-tests`) - Update aliases (`test`, `test-full`, `test-ef`) to use existing nextest equivalents - Update contributing documentation to use nextest examples - Fix example commands that previously referenced non-existing packages (`ssz`/`eth2_ssz`) Co-Authored-By: Daniel Ramirez-Chiquillo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Fixes #7835
Proposed Changes
test-release,test-debug,run-ef-tests)test,test-full,test-ef) to use existing nextest equivalentsssz/eth2_ssz)Additional Info
This resolves the contributor workflow inconsistency identified in #7835 where local development used cargo test while CI used nextest. While benchmarks showed nextest is only marginally faster (1.02x), the key benefit is consistency - having contributors use the same test runner as CI eliminates confusion and potential discrepancies between local development and CI results.
The decision prioritizes workflow consistency over the minimal performance difference, ensuring a unified testing approach across the project.
Testing performed:
make --dry-run test)cargo nextest run -p safe_arith)make cargo-fmt)