Re-export context_deserialize_derive inside context_deserialize
#7852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| all = ["derive", "milhouse", "ssz"] | ||
|
|
||
| [dependencies] | ||
| context_deserialize_derive = { version = "0.1.0", path = "../context_deserialize_derive", optional = true } |
Member
There was a problem hiding this comment.
Should this not just be workspace = true rather than path?
Member
There was a problem hiding this comment.
Nvm, looks like that generates a warning about the version being unused. And the combo of version + path is more future proof (aligned with what we'll want when we pull this crate out).
michaelsproul
approved these changes
Aug 12, 2025
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
LGTM
Was there anything else you wanted to add before merging?
michaelsproul
added
ready-for-merge
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Re-export
context_deserialize_deriveinside ofcontext_deserializeso they are both available from the same interface, which matches how popular crates (likeserde) handle this.This also nests both crates inside a new
context_deserializedirectory which will make it easier to eventually spin out into a different repo (if/when) we decide to do that (plus I prefer it aesthetically).Additional Info
I've also reorganized and added feature gates for external crate impls (
ssz_types, andmilhouse).