Skip to content

Lint-deps error after updating a dependency #4952

@Xhale1

Description

@Xhale1
  • I have searched open and closed issues for duplicates

Bug Description

Running yarn lint-deps reports errors after updating almost any dependency in the package.json. This causes yarn ready to fail.

This appears to be intentional from ts/util/lint/linter.ts, though there is no documentation around the purpose or role of this function. Several pull requests have mentioned this error but the specific reason for it seems to be elusive to contributors.

Steps to Reproduce

  1. Install clean project
  2. Update a dependency (for example Chai 4.1.2 -> 4.2.0)
  3. Install dependency with yarn install
  4. Run yarn lint-deps to get errors

Actual Result:

29493 files scanned. 1 questionable lines, 2 unused exceptions, 1785 total exceptions.
...
ERROR: "lint-deps" exited with 1.
error Command failed with exit code 1.

Expected Result:

Performing minor dependency updates, or at least patch bumps, should succeed or provide a clearer reason as to why it fails.

I'm trying to updated deps and modernize parts of this project but it's proving difficult.

Screenshots

Screen Shot 2021-01-26 at 6 28 31 PM

Platform Info

Signal Version:

1.39.6

Operating System:

MacOS 11.1

Linked Device Version:

N/A

Link to Debug Log

N/A

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions