libusb: allow hidapi to be configured without using iconv #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please see #373 |
Youw
reviewed
Nov 18, 2019
| @@ -390,7 +390,7 @@ static wchar_t *get_usb_string(libusb_device_handle *dev, uint8_t idx) | |||
| int len; | |||
| wchar_t *str = NULL; | |||
|
|
|||
| #ifndef __ANDROID__ /* we don't use iconv on Android */ | |||
| #if !defined(__ANDROID__) && !defined(NO_ICONV) /* we don't use iconv on Android */ | |||
There was a problem hiding this comment.
Suggested change
| #if !defined(__ANDROID__) && !defined(NO_ICONV) /* we don't use iconv on Android */ | |
| #if !defined(__ANDROID__) && !defined(NO_ICONV) /* we don't use iconv on Android, or when it is explicitly disabled */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, the idea is to allow users to configure hidapi without using iconv, as icvon may have dependencies that may not be supported