Support looping the playback, controlled by a button. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caches the interface name when onStart is called from the timer. Reorganization of the onStart function to make use of the caching. Adds a "replay" FXToggleButton to control the looping behavior.
|
Thanks for modifying the source. This is a very useful feature for an excellent utility. |
If the file can not be opened during onStart, re-enter the stopped state.
Since onStop is responsible for closing pcap_file, call it between each loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of my coworkers requested this functionality, and it was easy enough to "hack" in support. After some testing I was reasonably happy with it, and think it's useful.
I'm not sure if it conforms to all that you have in mind for the code base, but I think I conformed to the style nuances that I noticed. I'd be happy to rework it if you thought it useful but not quite what you would have intended.
(Also I noticed after pushing that the commit message wasn't quite worded right in the first explanation sentence, but I'm not too concerned about that I guess.)