Flutter release/3.16.3

.clang-tidy

@@ -1,40 +1,49 @@
+# A YAML format of https://clang.llvm.org/extra/clang-tidy/.
+
 # Prefix check with "-" to ignore.
-# Note: Some of the checks here are used as errors selectively, see
-# //ci/lint.sh
-Checks: "bugprone-use-after-move,\
-bugprone-unchecked-optional-access,\
-clang-analyzer-*,\
-clang-diagnostic-*,\
-darwin-*,\
-google-*,\
-modernize-use-default-member-init,\
-objc-*,\
--objc-nsinvocation-argument-lifetime,\
-readability-identifier-naming,\
--google-build-using-namespace,\
--google-default-arguments,\
--google-objc-global-variable-declaration,\
--google-objc-avoid-throwing-exception,\
--google-readability-casting,\
--clang-analyzer-nullability.NullPassedToNonnull,\
--clang-analyzer-nullability.NullablePassedToNonnull,\
--clang-analyzer-nullability.NullReturnedFromNonnull,\
--clang-analyzer-nullability.NullableReturnedFromNonnull,\
-performance-move-const-arg,\
-performance-unnecessary-value-param"
+Checks: >-
+  bugprone-use-after-move,
+  bugprone-unchecked-optional-access,
+  clang-analyzer-*,
+  clang-diagnostic-*,
+  darwin-*,
+  google-*,
+  modernize-use-default-member-init,
+  objc-*,
+  -objc-nsinvocation-argument-lifetime,
+  readability-identifier-naming,
+  -google-build-using-namespace,
+  -google-default-arguments,
+  -google-objc-global-variable-declaration,
+  -google-objc-avoid-throwing-exception,
+  -google-readability-casting,
+  -clang-analyzer-nullability.NullPassedToNonnull,
+  -clang-analyzer-nullability.NullablePassedToNonnull,
+  -clang-analyzer-nullability.NullReturnedFromNonnull,
+  -clang-analyzer-nullability.NullableReturnedFromNonnull,
+  performance-move-const-arg,
+  performance-unnecessary-value-param
 
 CheckOptions:
-  - key:    modernize-use-default-member-init.UseAssignment
-    value:  true
-  - key:    readability-identifier-naming.EnumConstantCase
-    value:  'CamelCase'
-  - key:    readability-identifier-naming.EnumConstantPrefix
-    value:  'k'
-  - key:    readability-identifier-naming.GlobalConstantCase
-    value:  'CamelCase'
-  - key:    readability-identifier-naming.GlobalConstantPrefix
-    value:  'k'
-  - key:    readability-identifier-naming.PrivateMemberCase
-    value:  'lower_case'
-  - key:    readability-identifier-naming.PrivateMemberSuffix
-    value:  '_'
+  - key: modernize-use-default-member-init.UseAssignment
+    value: true
+  - key: readability-identifier-naming.EnumConstantCase
+    value: "CamelCase"
+  - key: readability-identifier-naming.EnumConstantPrefix
+    value: "k"
+  - key: readability-identifier-naming.GlobalConstantCase
+    value: "CamelCase"
+  - key: readability-identifier-naming.GlobalConstantPrefix
+    value: "k"
+  - key: readability-identifier-naming.PrivateMemberCase
+    value: "lower_case"
+  - key: readability-identifier-naming.PrivateMemberSuffix
+    value: "_"
+
+# Lint headers within paths that contain "/flutter/" but not:
+# - gen         (generated code, the fact it compiles is good enough™)
+# - third_party (we didn't author most of the code, and can't fix the lints)
+#
+# Note this is because of our buildroot setup, so the full path of a lint is:
+# "../../flutter/impeller/core/runtime_types.h:1:1" as reported.
+HeaderFilterRegex: "(!third_party/)(!gen/).*/flutter/.*"

.github/PULL_REQUEST_TEMPLATE.md

@@ -10,7 +10,7 @@
 - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
 - [ ] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
 - [ ] I listed at least one issue that this PR fixes in the description above.
-- [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
+- [ ] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
 - [ ] I updated/added relevant documentation (doc comments with `///`).
 - [ ] I signed the [CLA].
 - [ ] All existing and new tests are passing.
@@ -20,6 +20,7 @@ If you need help, consider asking for advice on the #hackers-new channel on [Dis
 <!-- Links -->
 [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
 [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
+[test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
 [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine

.github/dependabot.yml

@@ -15,3 +15,9 @@ updates:
       # ignore patch versions, just rely on minor in order to update fewer times
       - dependency-name: "github/codeql-action"
         update-types: ["version-update:semver-minor"]
+  - package-ecosystem: "pub"
+    directory: "/lib/web_ui"
+    schedule:
+      interval: "daily"
+    labels:
+      - "autosubmit"

.github/labeler.yml

@@ -3,10 +3,16 @@
 # found in the LICENSE file.
 
 # See https://github.com/actions/labeler/blob/main/README.md for docs.
+'affects: desktop':
+  - shell/platform/darwin/common/**/*
+  - shell/platform/darwin/macos/**/*
+  - shell/platform/linux/**/*
+  - shell/platform/windows/**/*
+
 embedder:
   - shell/platform/embedder
 
-impeller:
+'e: impeller':
   - impeller/**/*
 
 platform-android:

.github/workflows/labeler.yml

@@ -17,4 +17,4 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     # Source available at https://github.com/actions/labeler/blob/main/README.md
-    - uses: actions/labeler@0967ca812e7fdc8f5f71402a1b486d5bd061fe20
+    - uses: actions/labeler@ac9175f8a1f3625fd0d4fb234536d26811351594

.github/workflows/scorecards-analysis.yml

@@ -22,7 +22,7 @@ jobs:
       id-token: write
     steps:
       - name: "Checkout code"
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9
+        uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608
         with:
           persist-credentials: false
       - name: "Run analysis"
@@ -41,7 +41,7 @@ jobs:
 
       # Upload the results as artifacts (optional).
       - name: "Upload artifact"
-        uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce
+        uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32
         with:
           name: SARIF file
           path: results.sarif

.github/workflows/third_party_scan.yml

@@ -25,11 +25,11 @@ jobs:
       id-token: write
     steps:
       - name: "Checkout code"
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9
+        uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608
         with:
           persist-credentials: false
       - name: "setup python"
-        uses: actions/setup-python@bd6b4b6205c4dbad673328db7b31b7fab9e241c0
+        uses: actions/setup-python@61a6322f88396a6271a6ee3565807d608ecaddd1
         with:
           python-version: '3.7.7' # install the python version needed
       - name: "extract and flatten deps"
@@ -38,7 +38,7 @@ jobs:
         run: python ci/scan_flattened_deps.py
       # Upload the results as artifacts.
       - name: "Upload artifact"
-        uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce
+        uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32
         with:
           name: SARIF file
           path: osvReport.sarif

.pylintrc

@@ -158,10 +158,10 @@ const-rgx=(([A-Z_][A-Z0-9_]*)|(__.*__))$
 class-rgx=[A-Z_][a-zA-Z0-9]+$
 
 # Regular expression which should only match correct function names
-function-rgx=[a-z_][a-z0-9_]{2,30}$
+function-rgx=[a-z_][a-z0-9_]{2,60}$
 
 # Regular expression which should only match correct method names
-method-rgx=[a-z_][a-z0-9_]{2,30}$
+method-rgx=[a-z_][a-z0-9_]{2,60}$
 
 # Regular expression which should only match correct instance attribute names
 attr-rgx=[a-z_][a-z0-9_]{2,30}$

AUTHORS

@@ -23,4 +23,5 @@ Koutaro Mori <[email protected]>
 TheOneWithTheBraid <[email protected]>
 Twin Sun, LLC <[email protected]>
 Qixing Cao <[email protected]>
-LinXunFeng <[email protected]>
+LinXunFeng <[email protected]>
+Amir Panahandeh <[email protected]>

BUILD.gn

@@ -20,11 +20,15 @@ declare_args() {
 
 config("config") {
   include_dirs = [ ".." ]
+  cflags = []
   if (is_win) {
     if (current_cpu != "x86") {
-      cflags = [ "/WX" ]  # Treat warnings as errors.
+      cflags += [ "/WX" ]  # Treat warnings as errors.
     }
   }
+  if (is_clang) {
+    cflags += [ "-Wunreachable-code" ]
+  }
 }
 
 config("export_dynamic_symbols") {
@@ -141,6 +145,10 @@ group("unittests") {
         [ "//flutter/shell/platform/android:flutter_shell_native_unittests" ]
   }
 
+  if (is_ios) {
+    public_deps += [ "//flutter/shell/platform/darwin/ios:ios_test_flutter" ]
+  }
+
   # Compile all unittests targets if enabled.
   if (enable_unittests) {
     public_deps += [
@@ -183,7 +191,7 @@ group("unittests") {
     if (is_mac) {
       public_deps += [
         "//flutter/impeller/golden_tests:impeller_golden_tests",
-        "//flutter/shell/platform/darwin:flutter_channels_unittests",
+        "//flutter/shell/platform/darwin/common:framework_common_unittests",
         "//flutter/third_party/spring_animation:spring_animation_unittests",
       ]
     }

CONTRIBUTING.md

@@ -1,8 +1,6 @@
 Contributing to the Flutter engine
 ==================================
 
-[![Build Status](https://api.cirrus-ci.com/github/flutter/engine.svg)][build_status]
-
 _See also: [Flutter's code of conduct][code_of_conduct]_
 
 Welcome