Added support to alias interfaces (e.g., ifname0:1)#317
Merged
shirou merged 1 commit intoshirou:masterfrom Feb 21, 2017
Merged
Conversation
Author
|
This issue causes telegraf to fail. I create an issue on the telegraf project for this and referred to this PR. |
Owner
|
Thank you for reporting. I did not aware like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In linux, alias interfaces can end up in
/proc/net/devas shown below:Current parsing will delimit field on a
:only which results in:1as the first element of a line with an alias interface. This will result in an error as:1will not be parseable to an int later on.This PR changes the delimiter to
:(space added), correctly parsing alias interfaces as well.