Significantly reworked Windows architecture handling in Process module #1434
+60
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed several issues around struct and pointer sizing for 64-bit queries - Process handling now functions as expected on ARM64 Windows hosts
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing out killing processes on Windows ARM64 hosts, ran into an issue where it just didn't work. After digging into it, turned out to be the wrong memory address for the process itself.
Full disclosure, I'm not a Golang rockstar here - there's probably a smarter way to do this. But, this was functional on ARM64, as well as AMD64 (killing both X86 and AMD64 processes) as well as X86. Let me know what I can do / change to get this up to spec and worthy of merge :)