Skip to content

Conversation

@SaschaSchwarze0
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 commented Jan 26, 2022

Changes

Updating our outdated sample build strategy tools to recent versions before our upcoming release.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

Update build strategy tool: Trivy to 0.22.0, go-containerregistry/crane to 0.8.0

@SaschaSchwarze0 SaschaSchwarze0 added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label Jan 26, 2022
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Jan 26, 2022
@qu1queee qu1queee self-requested a review January 27, 2022 10:39
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2022
@qu1queee
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2022
@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-update-strategy-tools branch from 8e5abe6 to fc15861 Compare January 27, 2022 11:14
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2022
@SaschaSchwarze0 SaschaSchwarze0 changed the title Update BuildAh to 1.23.2, update Trivy to 0.22.0, update go-containerregistry/crane to 0.8.0 Update Trivy to 0.22.0, update go-containerregistry/crane to 0.8.0 Jan 27, 2022
@SaschaSchwarze0
Copy link
Member Author

SaschaSchwarze0 commented Jan 27, 2022

I just learned that a release that exists in https://github.com/containers/buildah/releases does not mean that there is also an image tag for that version in quay.io/containers/buildah. Instead, based on https://github.com/containers/buildah/blob/main/contrib/buildahimage/README.md, the stable image is only built once the buildah version is updated in Fedora. And Fedora still has 1.23.1, https://src.fedoraproject.org/rpms/buildah. I therefore removed the version bump of buildah from this PR.

Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0342700 into shipwright-io:main Jan 27, 2022
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-update-strategy-tools branch January 27, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants