Add the list of environments to be blocked on the creation of files inside /platform/env #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
release-note
shahulsonhal
force-pushed
the
env-block
branch
6 times, most recently
from
6d3952f to
0cd8819
Compare
SaschaSchwarze0
requested changes
Jan 3, 2022
Member
SaschaSchwarze0
left a comment
SaschaSchwarze0
left a comment
There was a problem hiding this comment.
Hi @shahulsonhal, thank you for putting the fix together. Some minor suggestions to improve readability.
samples/buildstrategy/buildpacks-v3/buildstrategy_buildpacks-v3-heroku_cr.yaml
Outdated
Show resolved
Hide resolved
samples/buildstrategy/buildpacks-v3/buildstrategy_buildpacks-v3-heroku_cr.yaml
Outdated
Show resolved
Hide resolved
samples/buildstrategy/buildpacks-v3/buildstrategy_buildpacks-v3-heroku_cr.yaml
Outdated
Show resolved
Hide resolved
samples/buildstrategy/buildpacks-v3/buildstrategy_buildpacks-v3-heroku_cr.yaml
Outdated
Show resolved
Hide resolved
samples/buildstrategy/buildpacks-v3/buildstrategy_buildpacks-v3-heroku_cr.yaml
Outdated
Show resolved
Hide resolved
shahulsonhal
force-pushed
the
env-block
branch
from
0cd8819 to
bea4215
Compare
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
shahulsonhal
force-pushed
the
env-block
branch
from
bea4215 to
1ed3c59
Compare
…nside /platform/env The creation of a file named PATH (corresponding to PATH system environment) inside /platform/env caused failure for [python source with requirements.txt](https://github.com/Azure-Samples/python-docs-hello-world). Update scripts in the Buildpack strategies samples with an array of blocklist system environments.
shahulsonhal
force-pushed
the
env-block
branch
from
1ed3c59 to
c045a8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The creation of a file named PATH (corresponding to
PATHsystem environment) inside/platform/envcaused failure for python source with requirements.txt when building with the Buildpack strategy.Update scripts in the Buildpack strategies samples with an array of blocklist system environments.
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes