Removes set incsearch which was copied from vim-sensible
#640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm one of the users who don't use
set incsearchand therefore haven't installed the plugintpope/vim-sensible.So for me this UI related setting was a surprise and even if I can disable it, I recommend to not copying this behaviour from
vim-sensible, as long as it is not a requirement for the core functionality ofvim-polyglot(I would be ok with vim/nvim changing the default so I can easily disable it, but I don't want to overwrite plugins which I don't expect to change an already set option)