fix: exclude directories from extension filter (issue #1693)#1991
Open
mitre88 wants to merge 2 commits intosharkdp:masterfrom
Open
fix: exclude directories from extension filter (issue #1693)#1991mitre88 wants to merge 2 commits intosharkdp:masterfrom
mitre88 wants to merge 2 commits intosharkdp:masterfrom
Conversation
added 2 commits
May 3, 2026 19:09
Broken symlinks were returning None for depth(), causing min-depth checks to fail. Now we track depth for BrokenSymlink entries and return it properly. Fixes sharkdp#1017
Collaborator
|
It looks like this includes changes from #1990 as well. I'm also not sure this is something we actually want. Directories can have extensions too, and limiting it to files is just a matter of using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #1693 - directories with matching extension suffix were incorrectly included in results. Now extension filter only applies to files, not directories.