🚨 Ignore docs when linting #510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, the build has started linting our `/docs/` folder. It's possible that this was an `eslint` bug, and that it should have always been linted, since we just use our `.gitignore` file (and the JS in our docs folder is ignored by its own, nested `.gitignore` file). This change bumps our version of `eslint`, and adds the `/docs`/ folder separately to be ignored by `eslint`.
| "lolex": "^5.1.1", | ||
| "mocha": "^8.2.1", | ||
| "nyc": "^14.1.1", | ||
| "ot-json0-v2": "ottypes/json0", |
There was a problem hiding this comment.
Interesting, why did we need to add this?
There was a problem hiding this comment.
Oh it just got moved when I ran npm install — I'd added this by hand before, and I guess I don't alphabet so good 🤦🏼♂️
There was a problem hiding this comment.
Oh right and I don't read diffs good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #509
For some reason, the build has started linting our
/docs/folder. It'spossible that this was an
eslintbug, and that it should have alwaysbeen linted, since we just use our
.gitignorefile (and the JS in ourdocs folder is ignored by its own, nested
.gitignorefile).This change bumps our version of
eslint, and adds the/docs/ folderseparately to be ignored by
eslint.