Skip to content

Add linting #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2019
Merged

Add linting #79

merged 1 commit into from
Jul 31, 2019

Conversation

alecgibson
Copy link
Contributor

This change adds linting through eslint, with config read across from
ShareDB

Add linting
d9d8c5a 
This change adds linting through `eslint`, with config read across from
[ShareDB][1]

[1]: share/sharedb#302
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 92.98% when pulling d9d8c5a on add-linting into 46f4cb6 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 92.98% when pulling d9d8c5a on add-linting into 46f4cb6 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 92.98% when pulling d9d8c5a on add-linting into 46f4cb6 on master.

@alecgibson
Copy link
Contributor Author

(Coverage decrease is because the linting has increased the number of lines in some places)

ericyhwang
ericyhwang approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@ericyhwang ericyhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me and Nate, thanks!

@ericyhwang ericyhwang merged commit 0d4a1ad into master Jul 31, 2019
@ericyhwang ericyhwang deleted the add-linting branch July 31, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericyhwang ericyhwang ericyhwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alecgibson @coveralls @ericyhwang