Skip to content

Conversation

shannah
Copy link
Owner

@shannah shannah commented Sep 7, 2025

No description provided.

@shannah shannah requested a review from Copilot September 14, 2025 14:04
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This RFC document introduces a comprehensive plan for implementing platform-specific bundles in jDeploy. The purpose is to reduce bundle sizes by 50-56% and improve performance by creating optimized bundles for each platform architecture instead of universal bundles that include all platform dependencies.

Key changes in this PR:

  • Added a comprehensive RFC document outlining the platform-specific bundles feature implementation
  • Created data models for Platform enumeration and ignore pattern handling
  • Implemented .jdpignore file support for flexible native library filtering
  • Added comprehensive test coverage for the new functionality

Reviewed Changes

Copilot reviewed 40 out of 40 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
rfc/platform-specific-bundles.md Main RFC document detailing the implementation strategy for platform-specific bundle support
shared/src/main/java/ca/weblite/jdeploy/models/Platform.java Platform enumeration defining supported platform-architecture combinations
shared/src/main/java/ca/weblite/jdeploy/models/JDeployProject.java Extended project model with platform bundle configuration methods
cli/src/main/java/ca/weblite/jdeploy/services/ New services for ignore file parsing, JAR processing, and bundle generation
tests/projects/TextEditor/CLAUDE.md Claude instructions for jDeploy setup guidance
Various test files Comprehensive test coverage for all new functionality including unit and integration tests

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@shannah shannah merged commit 5c547b8 into master Sep 14, 2025
10 checks passed
@shannah shannah deleted the feature/platform-specific-bundles branch September 14, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant