-
Notifications
You must be signed in to change notification settings - Fork 22
Added rfc document to plan the platform-specific bundles feature #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… tarballs are added
… npm packages for them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This RFC document introduces a comprehensive plan for implementing platform-specific bundles in jDeploy. The purpose is to reduce bundle sizes by 50-56% and improve performance by creating optimized bundles for each platform architecture instead of universal bundles that include all platform dependencies.
Key changes in this PR:
- Added a comprehensive RFC document outlining the platform-specific bundles feature implementation
- Created data models for Platform enumeration and ignore pattern handling
- Implemented .jdpignore file support for flexible native library filtering
- Added comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 6 comments.
Show a summary per file
File | Description |
---|---|
rfc/platform-specific-bundles.md | Main RFC document detailing the implementation strategy for platform-specific bundle support |
shared/src/main/java/ca/weblite/jdeploy/models/Platform.java | Platform enumeration defining supported platform-architecture combinations |
shared/src/main/java/ca/weblite/jdeploy/models/JDeployProject.java | Extended project model with platform bundle configuration methods |
cli/src/main/java/ca/weblite/jdeploy/services/ | New services for ignore file parsing, JAR processing, and bundle generation |
tests/projects/TextEditor/CLAUDE.md | Claude instructions for jDeploy setup guidance |
Various test files | Comprehensive test coverage for all new functionality including unit and integration tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
shared/src/main/java/ca/weblite/jdeploy/models/JDeployProject.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/ca/weblite/jdeploy/services/RecommendedIgnoreRulesService.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/ca/weblite/jdeploy/services/PlatformSpecificJarProcessor.java
Show resolved
Hide resolved
…java Co-authored-by: Copilot <[email protected]>
…eRulesService.java Co-authored-by: Copilot <[email protected]>
No description provided.