Skip to content

Conversation

samestep
Copy link
Contributor

@samestep samestep commented Aug 4, 2025

This PR adds a bit of explanation in tools/slang-test/README.md about how to ignore different kinds of tests.

@samestep samestep requested a review from a team as a code owner August 4, 2025 15:57
@samestep samestep added the pr: non-breaking PRs without breaking changes label Aug 4, 2025

Tests are identified by a special comment at the start of the test file: `//TEST:<type>:`

To ignore a test, use `//IGNORE_TEST:` instead of `//TEST:`.
Copy link
Collaborator

@ArielG-NV ArielG-NV Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is the decision we want in the documentation, I would guess that we should probably REGEX replace all DISABLE_TEST and related for consistency?

Copy link
Contributor Author

@samestep samestep Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively I could just write //DISABLE_TEST here instead, since there are 528 instances of that in the repo and only 3 of //IGNORE_TEST.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although there are also 94 instances of DISABLED_TEST (different from DISABLE_TEST).

@csyonghe csyonghe added this pull request to the merge queue Aug 6, 2025
Merged via the queue into master with commit ea600fa Aug 6, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants