Skip to content

Johnphamous/eng-1210-cli-should-convey-kyckyb-info #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

JohnPhamous
Copy link
Contributor

No description provided.

Copy link

semanticdiff-com bot commented Feb 28, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  package.json  98% smaller
  src/lib/me.ts  0% smaller

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR improves error handling for accounts under review by adding specific messaging for 403 responses in the CLI.

  • Added clear error message in src/lib/me.ts for users whose accounts are still under review (403 status code)
  • Included contact information ([email protected]) in the error message for users to reach out with questions
  • Bumped package version from 0.1.57 to 0.1.58 in package.json to reflect this improvement
  • Prevents generic "Failed to fetch account info" error when the specific issue is related to KYC/KYB verification

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@JohnPhamous JohnPhamous merged commit 20c51bb into main Feb 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant