Integration of BN (BigNum) functions. #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fn BN_CTX_new() -> *mut BN_CTX; | ||
| fn BN_CTX_free(ctx: *mut BN_CTX); | ||
|
|
||
| fn BN_set_word(bn: *mut BIGNUM, n: c_uint) -> c_int; |
There was a problem hiding this comment.
The man pages say that this takes an unsigned long which would correspond to c_ulong, not c_uint.
|
I've removed the resource leak and corrected the interface inaccuracies. Thanks for pointing them out. |
sfackler
added a commit
that referenced
this pull request
Jul 25, 2014
Integration of BN (BigNum) functions.
DiamondLovesYou
pushed a commit
to DiamondLovesYou/rust-openssl
that referenced
this pull request
Sep 1, 2014
Remove LWS collapsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've included tests for those functions/methods that are not simple wrappers around their C counterparts.
All functions/methods are checked for errors in their return values and will produce either a BigNum or SslError. However, for those methods which are implemented for traits (e.g. .add(), sub(), etc.), the underlying operation is assumed to have succeeded. Thus, if one of these methods fails, the result will be as if you attempted to unwrap a Result type value.