-
-
Notifications
You must be signed in to change notification settings - Fork 213
Add preliminary ALPN support for OpenSSL backend #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Seems CI failures are unhappy about lazy_static 0.2. |
I don't really want to support a feature that only works on one backend - the whole point of this crate is that it'll work anywhere! |
src/imp/openssl.rs
Outdated
let alpn = builder | ||
.alpn_protocols | ||
.iter() | ||
.map(|proto| format!("\\x{:x}{}", proto.len(), proto)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sequence that openssl wants is literally the byte length of the protocol followed by it, not the string \xN
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, my eyes tricked me when reading https://github.com/sfackler/hyper-openssl/blob/master/src/lib.rs#L107.
I assumed as mentioned in #49, support for backends could be added in as they exist. |
All of the underlying system APIs support ALPN. |
31a1307
to
64af7e0
Compare
I don't see anything about ALPN in the schannel docs... |
So to clarify, you'd rather not provide the API in |
Yep. |
No description provided.