Skip to content

Conversation

seanmonstar
Copy link

No description provided.

@seanmonstar
Copy link
Author

Seems CI failures are unhappy about lazy_static 0.2.

@sfackler
Copy link
Owner

sfackler commented Jan 3, 2019

I don't really want to support a feature that only works on one backend - the whole point of this crate is that it'll work anywhere!

let alpn = builder
.alpn_protocols
.iter()
.map(|proto| format!("\\x{:x}{}", proto.len(), proto))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sequence that openssl wants is literally the byte length of the protocol followed by it, not the string \xN.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanmonstar
Copy link
Author

I assumed as mentioned in #49, support for backends could be added in as they exist.

@sfackler
Copy link
Owner

sfackler commented Jan 3, 2019

All of the underlying system APIs support ALPN.

@seanmonstar
Copy link
Author

I don't see anything about ALPN in the schannel docs...

@sfackler
Copy link
Owner

sfackler commented Jan 4, 2019

steffengy/schannel-rs#49

@seanmonstar
Copy link
Author

So to clarify, you'd rather not provide the API in native-tls until all 3 backends have the features available? I figured we could add support individually, since it's mostly an optimization, and things should still work if not available.

@sfackler
Copy link
Owner

sfackler commented Jan 6, 2019

So to clarify, you'd rather not provide the API in native-tls until all 3 backends have the features available?

Yep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants