-
Notifications
You must be signed in to change notification settings - Fork 36
backoff: remove global rand.Seed and using locked rand.Rand #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Koichi Shiraishi <[email protected]>
Owner
|
What's the reason for the mutex? |
Contributor
Author
|
@sethvargo Just mimic
|
Contributor
Author
|
implemented |
Signed-off-by: Koichi Shiraishi <[email protected]>
d6236a4 to
dc94ec5
Compare
Signed-off-by: Koichi Shiraishi <[email protected]>
dc94ec5 to
0c1804f
Compare
- lockedSource struct with 16 pointer bytes could be 8 Signed-off-by: Koichi Shiraishi <[email protected]>
sethvargo
reviewed
Dec 12, 2022
Signed-off-by: Koichi Shiraishi <[email protected]>
Signed-off-by: Koichi Shiraishi <[email protected]>
Contributor
Author
|
@sethvargo PTAL |
sethvargo
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rand.Seedwill affect globally. Remove it, and implements mutex lockedrand.Randsimilar of stdlib.