Skip to content

[SES-4217] - In-app review #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jul 23, 2025
Merged

[SES-4217] - In-app review #1349

merged 17 commits into from
Jul 23, 2025

Conversation

SessionHero01
Copy link
Collaborator

@SessionHero01 SessionHero01 commented Jul 22, 2025 •
edited
Loading

This PR implements the rest of the in-app review feature, including:

  1. Tidy-up naming, dependency injection for the manager classes
  2. Adds InAppReviewViewModel and its compose functions
  3. Adds test

Screen_recording_20250722_165146.webm
Screen_recording_20250722_165007.webm

@SessionHero01
Copy link
Collaborator Author

@ThomasSession Simplified the state management inside the view model and got rid of the string manipulation in VM

@SessionHero01 SessionHero01 merged commit 3bdd202 into dev Jul 23, 2025
4 checks passed
@SessionHero01 SessionHero01 deleted the ses-4217-in-app-review branch July 23, 2025 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasSession ThomasSession ThomasSession approved these changes

@jbsession jbsession jbsession approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SessionHero01 @ThomasSession @jbsession