Fix behavior of multibyte characters in W4#87
Closed
Manishearth wants to merge 1 commit intoservo:masterfrom
Closed
Fix behavior of multibyte characters in W4#87Manishearth wants to merge 1 commit intoservo:masterfrom
Manishearth wants to merge 1 commit intoservo:masterfrom
Conversation
This was referenced Dec 18, 2022
Manishearth
force-pushed
the
w4-multibyte
branch
from
434f5b7 to
9ff3c9a
Compare
Member
Author
|
or r? @eggrobin |
Contributor
|
☔ The latest upstream changes (presumably #85) made this pull request unmergeable. Please resolve the merge conflicts. |
Manishearth
force-pushed
the
w4-multibyte
branch
from
9ff3c9a to
7fb3488
Compare
Member
Author
|
Merged in with #91 since it's the same area of code and I don't want to juggle a billion PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found whilst investigating #86. It's not necessarily the best way to do it, but it does fix some tests, and it's probably the best path forward until we know what we're doing in #86
r? @mbrubeck or @sffc