-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Updating node verson #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating node verson #422
Conversation
There are a few more examples that still use nodejs6.10, could you update those too? https://github.com/serverless/examples/search?q=%22runtime%3A+nodejs6.10%22 |
Updated the rest of them, should be good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest updating runtime to recommended nodejs12.x
.
When I was trying to sls deploy
one of the examples using nodejs8.10
, I got this error
Serverless Error ---------------------------------------
An error occurred: TimeLambdaFunction - The runtime parameter of nodejs8.10 is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (nodejs12.x) while creating or updating functions.
Also, according to AWS deprecation schedule, even updating of Node.js 8.10 will be very soon deprecated.
P.S. This is my first code review. My motivation is that I also encountered deprecation runtime errors while using these examples. I hope this review will speed up things with merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update needed from nodejs8.10
to nodejs12.x
Updated existing examples to nodejs12.x to leverage latest supported runtime. |
@ColtonHerrodWork I know this review is long overdue. I'm sorry about that. I'd like to merge this right away! Could you just fix the conflicts? 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ColtonHerrodWork you have a possibility to resolve that merge conflict ? or would you like a hand ? |
@fvant I see. It seems there is no activity. So if you decide to create a PR, you may ping me to make a code review |
@preshetin created #501 with resolved merge conflict |
Updating the node version for the example TODO application since 6.x is no longer supported in Lambda.