Skip to content

Conversation

huxuan
Copy link
Member

@huxuan huxuan commented Mar 6, 2024


📚 Documentation preview 📚: https://ss-python--368.org.readthedocs.build/en/368/

@huxuan huxuan marked this pull request as draft March 6, 2024 03:25
@huxuan huxuan force-pushed the xuan.hu/py3.8-compatibility branch 2 times, most recently from 465fcbe to 6e90c05 Compare March 6, 2024 04:04
@huxuan huxuan linked an issue Mar 6, 2024 that may be closed by this pull request
@huxuan huxuan force-pushed the xuan.hu/py3.8-compatibility branch 2 times, most recently from adfc430 to 50d0235 Compare March 6, 2024 05:25
@huxuan huxuan marked this pull request as ready for review March 6, 2024 11:51
@huxuan huxuan requested a review from msclock March 6, 2024 11:51
@huxuan
Copy link
Member Author

huxuan commented Mar 6, 2024

@msclock This is the best solution I can come up with for the back compatibility hack.

It will install pre-commit 3.5.0 for Python 3.8 and will install the latest version for Python 3.9 and higher. Besides, the latest version is pinned and can be updated with renovate while the version 3.5.0 is pinned forever.

Any comments are welcome. :-)

@msclock
Copy link
Contributor

msclock commented Mar 7, 2024

@msclock This is the best solution I can come up with for the back compatibility hack.

It will install pre-commit 3.5.0 for Python 3.8 and will install the latest version for Python 3.9 and higher. Besides, the latest version is pinned and can be updated with renovate while the version 3.5.0 is pinned forever.

Any comments are welcome. :-)

Emm..., I consider the command without the pinned version pipx install pre-commit can dramatically reduce the implementation complexity.🤣

@huxuan
Copy link
Member Author

huxuan commented Mar 7, 2024

Emm..., I consider the command without the pinned version pipx install pre-commit can dramatically reduce the implementation complexity.🤣

That is the state before renovate integration but may not be the best practice. Since we enabled the build cache, no pinned version will be treated as cache hit even when a new version released.

@msclock
Copy link
Contributor

msclock commented Mar 7, 2024

Emm..., I consider the command without the pinned version pipx install pre-commit can dramatically reduce the implementation complexity.🤣

That is the state before renovate integration but may not be the best practice. Since we enabled the build cache, no pinned version will be treated as cache hit even when a new version released.

I see the multiple phase build cache silences the update of pre-commit. The pr now is the solution.👌

@huxuan huxuan force-pushed the xuan.hu/py3.8-compatibility branch from 20acb6d to 3fe244e Compare March 7, 2024 02:35
@huxuan huxuan enabled auto-merge (squash) March 7, 2024 02:36
@huxuan huxuan merged commit d99abdc into serious-scaffold:main Mar 7, 2024
@huxuan huxuan deleted the xuan.hu/py3.8-compatibility branch March 7, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Python 3.8 support
2 participants