-
-
Notifications
You must be signed in to change notification settings - Fork 12
chore: fix Python 3.8 compatibility issue #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix Python 3.8 compatibility issue #368
Conversation
465fcbe
to
6e90c05
Compare
adfc430
to
50d0235
Compare
@msclock This is the best solution I can come up with for the back compatibility hack. It will install pre-commit 3.5.0 for Python 3.8 and will install the latest version for Python 3.9 and higher. Besides, the latest version is pinned and can be updated with renovate while the version 3.5.0 is pinned forever. Any comments are welcome. :-) |
Emm..., I consider the command without the pinned version |
That is the state before renovate integration but may not be the best practice. Since we enabled the build cache, no pinned version will be treated as cache hit even when a new version released. |
I see the multiple phase build cache silences the update of pre-commit. The pr now is the solution.👌 |
20acb6d
to
3fe244e
Compare
📚 Documentation preview 📚: https://ss-python--368.org.readthedocs.build/en/368/