Fixes a number of issues with LoggerSinkConfiguration.Wrap()
#1165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fied in serilog#1154 - Ensures that `wt.X(); wt.Y()` and `wt.X().WriteTo.Y()` are equivalent - Ensures a failing sink doesn't block events from reaching others inside the same wrapper, much as using a secondary logger would do - Prevents chained calls from accidentally breaking thread-safety rules by turning `Enrich` inside wrappers into a no-op
2 tasks
|
👍 |
bartelink
reviewed
May 13, 2018
| configureWrappedSink(capturingLoggerSinkConfiguration); | ||
|
|
||
| return loggerSinkConfiguration._loggerConfiguration; | ||
| if (!sinksToWrap.Any()) |
There was a problem hiding this comment.
Might as well grab Count as it's used 3 lines down
This was referenced May 17, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were identified via the discussion in #1154.
wt.X(); wt.Y()andwt.X().WriteTo.Y()are equivalentEnrichinside wrappers into a no-opWhat issue does this PR address?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: